search

kazu-yamamoto / pgpdump

A PGP packet visualizer
http://www.mew.org/~kazu/proj/pgpdump/
BSD 3-Clause "New" or "Revised" License
174 stars 33 forks source link

Gf apgpdump #32

Closed galaxiesFarApart closed 2 years ago

galaxiesFarApart commented 2 years ago

upload modifications to support GnuPG-2.3.3 ECC curves, additional hash and algorithm names

galaxiesFarApart commented 2 years ago

Hmmmm - I have actual gpg-2.3.3 keys that I generated to use and review via "hexedit", that use a fictitious "userid", but don't know if valid keys would be best. One key for every key-type minus "smart card" since I don't have one.

For the initial testing, I copied out 20 bytes of an actual key so that I could get a "look" at the first public key data packet, ECC portion.

Sent from my iPad - J.Dutton

On Dec 2, 2021, at 6:58 PM, Kazu Yamamoto @.***> wrote:

 @kazu-yamamoto requested changes on this pull request.

Looks excellent! It would be nice if we had test data for this change in the data/ directory.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

galaxiesFarApart commented 2 years ago

I also have output files for all of the keys tested as well as correlated gpg-2.3.3 "--list-packets" output files.

On Dec 2, 2021, at 6:58 PM, Kazu Yamamoto @.***> wrote:

 @kazu-yamamoto requested changes on this pull request.

Looks excellent! It would be nice if we had test data for this change in the data/ directory.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

kazu-yamamoto commented 2 years ago

A fictitious id such as alice@example.com is good. But if you hesitate to add such data, I will merge this PR as is.

kazu-yamamoto commented 2 years ago

Merged. Thank you for your contribution! If you wish, I will release a new version.

galaxiesFarApart commented 2 years ago

Yes - go ahead and release it.

On Dec 6, 2021, at 6:54 PM, Kazu Yamamoto @.***> wrote:

 Merged. Thank you for your contribution! If you wish, I will release a new version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

kazu-yamamoto commented 2 years ago

Version 0.34 has been released. https://www.mew.org/~kazu/proj/pgpdump/en/