search

kazu-yamamoto / quic

IETF QUIC library in Haskell
BSD 3-Clause "New" or "Revised" License
91 stars 13 forks source link

Unnecessary forever. #6

Closed kazu-yamamoto closed 4 years ago

kazu-yamamoto commented 4 years ago

@ocheron Would you check ef050773ca466d42bbd0a8d13dc5e5ea6c15e4bb? I think the thread for the second client handshake cannot finish due to this forever. Even after removing this forever, my interoperability tests against other implementations also pass.

kazu-yamamoto commented 4 years ago

The SHA1 value was wrong. I edited and corrected it.

ocheron commented 4 years ago

I added the forever in case the TLS library is able to handle several tickets. Normally the thread is killed with HandshakeDone.

The forever can be removed if this is causing issues, but that means QUIC will not even parse the rest of the handshake messages received.

kazu-yamamoto commented 4 years ago

I understand your intention. Thank you!