Closed GoogleCodeExporter closed 9 years ago
This is really two problems.
1. Cant upload files from the page-edit screen.
2. Cant insert files that are already uploaded into a page without raw HTML.
#1 is an issue, but on the backburner until #2 gets fixed. Mike is working on
integrating a file browser into 3.0 - We will have to wait to see how that
works before we go any further.
Original comment by ccagle8
on 31 Jan 2011 at 3:01
Looks like file manager plugin got uploaded in recent SVN commits, but it is
just too big. And style is far off from GetSimple, not to mention all
localization problems.
Here's my proposal - let's use modified upload.php file. Everything we need is
already there and working: file upload, directories, image preview.
I've done a quick hack just to see if it works - yes, it does. Although there
are some minor issues with paths when GetSimple is installed in directory and
styling is quite off, but I think it might be better alternative to that big
file manager plugin.
Original comment by jos...@gmail.com
on 15 Feb 2011 at 8:40
Attachments:
Forgot to mention that you'll need to copy filebrowser.php to admin/ directory
and change edit.php "filebrowserBrowseUrl" parameter to "filebrowser.php".
Original comment by jos...@gmail.com
on 15 Feb 2011 at 8:41
agreed... it's not production ready yet. Hopefully Mike or I will find time to
work on it shortly.
Original comment by ccagle8
on 15 Feb 2011 at 9:20
Issue 130 has been merged into this issue.
Original comment by ccagle8
on 15 Feb 2011 at 9:21
But still, your proposed filemanager plugin is quite old - it uses
jquery-1.2.6. And it has internal, totally different uploader script. I suggest
to keep file browser simple and use parts of code already present in GetSimple
- file listing from upload.php and uploadify for file uploading. We can move
uploadify to it's own script file, so it could be used anywhere in GetSimple
(maybe even plugins).
Original comment by jos...@gmail.com
on 16 Feb 2011 at 11:02
agreed, but it hasnt been whittled down. I plan on removing features and
changing it to use the jquery that is already part of the GS install... If it
doesnt work, we will/can find another one.
Original comment by ccagle8
on 16 Feb 2011 at 1:04
KCFinder (http://kcfinder.sunhater.com/) was proposed in forums. It looks a bit
better, might take less space with big images removed, but I don't really like
selecting options from context menus.
Original comment by jos...@gmail.com
on 16 Feb 2011 at 1:09
I'd like to propose an alternative solution - do not add fully featured file
manager to GetSimple core, but make it easier to add one as plugin. That way
GetSimple is left small and lean - not everyone needs full file manager.
Original comment by jos...@gmail.com
on 27 Feb 2011 at 2:35
I will check out your script and let you know. I agree that we probably a full
featured manager, so I will give yours a shot. I assume it's the one you
published in the forums?
Original comment by ccagle8
on 27 Feb 2011 at 6:38
Yes, that's the one. Currently working on plugin version of the same script,
but it is easier to set up when it resides in admin/ directory.
Original comment by jos...@gmail.com
on 27 Feb 2011 at 7:41
well, do you mind if we use this and/or the page link module as a core feature?
I think the main reason we were initially looking for canned versions we could
just "plugin" was because we didnt know or have time to develop one. I would be
glad to keep all recognition to you if we use them of course...
Original comment by ccagle8
on 28 Feb 2011 at 5:51
No problem, I would be happy if filebrowser and page link scripts ended up in
core. No special recognition is necessary, because I just took existing code
and modified it a bit to work in this special case ;)
Original comment by jos...@gmail.com
on 28 Feb 2011 at 6:14
The first part of this has been added to the svn. TODOS:
- add support to link to thumbnails
- add support for internal folders inside /uploads/)
Original comment by ccagle8
on 11 Mar 2011 at 9:55
I updated filebrowser to latest version - I had already fixed most of issues,
but forgot to upload it.
Original comment by jos...@gmail.com
on 12 Mar 2011 at 1:05
closing this as it is done, we are just working out some kinks with the
filebrowser. If anything major pops up, lets create a new Issue
Original comment by ccagle8
on 13 Mar 2011 at 2:16
Original issue reported on code.google.com by
grantov...@gmail.com
on 22 Jan 2011 at 8:18