search

kazuhikoarase / qrcode-generator

QR Code Generator implementation in JavaScript, Java and more.
https://kazuhikoarase.github.io/qrcode-generator/js/demo/
MIT License
2.1k stars 674 forks source link

Fixing a few PHP warnings #107

Open rdwebdesign opened 2 years ago

rdwebdesign commented 2 years ago

This PR fix the warning received when the code (between lines 66 and 89) calls new inside addDataImpl(). Example:

    $this->addDataImpl(new QRNumber($data));

Also fixes the PHP Notice: A non well formed numeric value encountered... received when the code for printSVG() encounters a string where a numeric type is expected.

rdwebdesign commented 2 years ago

@kazuhikoarase

Do you need more information about the fixed code?