kazuhikoarase / qrcode-generator

QR Code Generator implementation in JavaScript, Java and more.
https://kazuhikoarase.github.io/qrcode-generator/js/demo/
MIT License
2.12k stars 680 forks source link

Added node.js compatibility, mocha test and patches from other forks #6

Open Hypermediaisobar-admin opened 9 years ago

Hypermediaisobar-admin commented 9 years ago

Hi,

First of all, thanks for your work :).

We've added some glue code that allows using qrcode.js in nodejs.

Additionally, we've:

It would be great if you could merge it all into official repo. Please let us know if anything has to be changed before merge, or if those changes cannot be merged at all for some reason.

Thanks, Regards

marksteward commented 9 years ago

Not the maintainer, but I'd suggest removing the reindent (45d0c74), as it makes it impossible to see what the changes are.

ahwayakchih commented 6 years ago

@marksteward you're absolutely right. I reapplied changes in a new pull request :).

ahwayakchih commented 6 years ago

@kazuhikoarase please close this, as it was implemented in #54 :).