Add a11y to inline SVG - Githubissues

kazuhikoarase / qrcode-generator

QR Code Generator implementation in JavaScript, Java and more.

https://kazuhikoarase.github.io/qrcode-generator/js/demo/

MIT License

2.1k stars 674 forks source link

Add a11y to inline SVG #74

Closed otacke closed 4 years ago

otacke commented 4 years ago

Will improve accessibility for people who are visually impaired. Uses common method to mimic the title and alt properties of img elements for inline SVGs.

Will add two new arguments to createSvgTag:

{string|object} alt - Alternate description text (string) or alt text and individual element id (object) as {text: altText, id: individualId}
{string|object} title - Alternate title text (string) or title text and individual element id (object) as {text: titleText, id: individualId}

kazuhikoarase commented 4 years ago

thanks a lot!

otacke commented 4 years ago

You're welcome! Sorry for not directing the pull request to development. The project I work on the most has reversed logic with the master branch being the development version, and I forgot to check.