search

kazuhikoarase / qrcode-generator

QR Code Generator implementation in JavaScript, Java and more.
https://kazuhikoarase.github.io/qrcode-generator/js/demo/
MIT License
2.1k stars 674 forks source link

Port this package to hacklang #78

Closed lexidor closed 4 years ago

lexidor commented 4 years ago

I've been using this software in a project for a year now. Your software is high quality. I can't release the version I am using, because I made many Lexidor specific assumptions. However, I like this package so much, that I decided to port it a second time and give back to you.

Hacklang HHVM

lexidor commented 4 years ago

@kazuhikoarase What is your stance on supporting another language (Hack)? If you feel like you are already supporting enough languages, I would be willing to publish this as a separate package.

kazuhikoarase commented 4 years ago

Hi,

I'm very interested in your code so I wanted to learn a new language and read your code before commit.

But I couldn't make time for it...

I have just merged yours.

Thanks a lot.

lexidor commented 4 years ago

I'm very interested in your code so I wanted to learn a new language and read your code before commit.

Hack is indeed an amazing language. It let's you reuse a lot of PHP knowledge. It also allows you to write code safer using its static type system. It has allowed me to grow with tiny steps. It made me a better programmer, both in Hack aswell as in PHP.

Feel free to poke around in the language. You will learn a lot about PHP in the process, so even if you decide Hack isn't for you, you can still reuse what it taught you in PHP.