kazuhisya / dia-aws-simple-icons

AWS Simple Icons for dia
25 stars 8 forks source link

errors when deleting spaces from directory and file names #3

Open bantaj opened 7 years ago

bantaj commented 7 years ago

I am getting the following errors when trying to run this in Ubuntu. Similar errors being thrown for the next step in the script to modify filenames:

delete space: dir
mv: missing file operand
Try 'mv --help' for more information.
mv: cannot stat 'terprise Applicatio': No such file or directory
mv: cannot stat 's'$'\n''./Compute & Networki': No such file or directory
mv: cannot stat 't & Ma': No such file or directory
mv: cannot stat 't'$'\n''./App Services'$'\n''./O': No such file or directory
mv: cannot stat 'd Workforce'$'\n''./Admi': No such file or directory
mv: cannot stat ' & Security'$'\n''./A': No such file or directory
mv: cannot stat 'alytics'$'\n''./Mobile Services'$'\n''./Storage & Co': No such file or directory
mv: cannot stat 't Delivery'$'\n''./Database'$'\n''./SDKs': No such file or directory
delete "&": dir
./build.sh: 25: ./build.sh: Bad substitution
kazuhisya commented 7 years ago

These assumes that /bin/sh is bash , but in ubuntu the default is dash . This script is not POSIX compliant (this is because I was corner‐cutting in the construction...)

Later I'll fix shebang.

bantaj commented 7 years ago

Changing to bash fixed it. Thank you!

One thing I noticed when looking at the resulting images is some might be missing (e.g. AWS API Gateway). Interestingly, I looked in their most recent collection and dont see it there either:

https://media.amazonwebservices.com/AWS-Design/Arch-Center/16.2.22_Update/AWS_Simple_Icons_EPS-SVG_v16.2.22.zip

Here's the one that appears to be missing: http://kinlane-productions.s3.amazonaws.com/api-evangelist-site/blog/aws-api-gateway-icon.png

kazuhisya commented 7 years ago

Thank you for letting me know!

ooops, As I confirmed this page , it seems that the URL to latest icon set has changed. and, the directory in zip seems to have changed. So a little hard fix is needed.

Give me some time to fix it.

kazuhisya commented 7 years ago

Hi, @bantaj

Compatible with 16.2.22 (4aa6d16) Could you please give it a try?