kazukidb / kazuki

Kazuki: a harmonious data store
Other
5 stars 4 forks source link

SecondaryIndexStore is not updating the index on entity updates #20

Closed mcculls closed 10 years ago

mcculls commented 10 years ago

https://issues.sonatype.org/browse/NX-452

Somewhere between 0.4.2 and 0.5.4 the SecondaryIndexStore has stopped updating the index on entity updates, causing FileBlobStoreIT to fail: http://bamboo.s/browse/NX-OSSF29-G0-5/test/case/86955626

The blob-store uses a secondary index to find blobs that have a state attribute equal to MARKED_FOR_DELETION: (note this code still uses the enum->string workaround)

https://github.com/sonatype/nexus-oss/blob/blobstore-file/components/nexus-blobstore-file/src/main/java/org/sonatype/nexus/blobstore/file/kazuki/KazukiBlobMetadataStore.java#L188

Debugging shows that while the state field of the blob entity has been updated to MARKED_FOR_DELETION, the index still acts as if the state was still CREATED.

sunnygleason commented 10 years ago

fixed in KZ 0.5.6 - please verify, or let me know if it's still an issue!

sunnygleason commented 10 years ago

(fix commit and tests are here: https://github.com/kazukidb/kazuki/commit/d44e8e98d854b498fa3231fc702c2dbe7e043c82 )

mcculls commented 10 years ago

Fix looks good, thanks: http://bamboo.s/browse/NX-OSSF29-6

mcculls commented 10 years ago

Closing as fixed