Closed kazurayam closed 2 years ago
It is not a good idea to have "PreferencesModifiers" class in 2 different packages. It is better to keep them named "ChromePreferencesModifies" and "FirefoxPreferencesModifies"
I moved com.kazurayam.webdriverfactory.chrome.PreferencesModifier to com.kazurayam.webdriverfactory.PreferencesModifier.
When I restarted working on Firefox, I found it ugly. A single class PreferencesModifier is shared by Chrome and Firefox together, which looks ugly.
I feel, better to seperate it into 2 for Chrome and FIrefox each
in v0.2.7, i have
https://github.com/kazurayam/webdriverfactory/blob/0.2.7/src/main/groovy/com/kazurayam/webdriverfactory/chrome/ChromePreferencesModifier.groovy
https://github.com/kazurayam/webdriverfactory/blob/0.2.7/src/main/groovy/com/kazurayam/webdriverfactory/chrome/ChromePreferencesModifiers.groovy
A preferences is just a Map<String, Object>, not specific to Chrome. Therefore it should be moved to the higher level of package and renamed
This is good to avoid code duplication in Chrome and Firefox
However, the "PreferencesModifiers" are unique e to Chrome and Firefox each, so they should be renamed , in the same page, to