com.kazurayam.inspectus.materialize.discovery.Sitemap and related classes don't work well

[kazurayam]

derived from

https://github.com/kazurayam/ks_comparingElementScreenshots_using_Inspectus/issues/2

I should start with reviewing the design of com.kazurayam.inspectus.materialize.discovery.Sitemap class.

[kazurayam]

See the source of Sitemap class:

https://github.com/kazurayam/inspectus/blob/0.10.2/src/main/java/com/kazurayam/inspectus/materialize/discovery/Sitemap.java

Sitemap implements methods

• public Target deriveTwinTarget(Target base)

This method makes the design of Sitemap class very complicated.

But, is this method really used by someone?

I am afraid not.

[kazurayam]

See

https://github.com/kazurayam/inspectus4katalon-sample-project/blob/0.5.2/Scripts/MyAdmin/materialize/Script1667687365090.groovy

This code is the only code that uses the Sitemap class. You can see that this code does NOT use the deriveTwinTarget(Target base) method.

So, I think that the Sitemap class can be much more simplified.

[kazurayam]

• added the com.kazurayam.inspectus.materialize.discovery.Sitemap2 class
• added the com.kazurayam.inspectus.materialize.discovery.SitemapLoader2 class

SitempaLoader supports string interpolation "${URL_PREFIX}" => "http://hostname", which simplifies many things

[kazurayam]

I will remove the existing 2 classes

• com.kazurayam.inspectus.materialize.discovery.Sitemap class
• com.kazurayam.inspectus.materialize.discovery.SitemapLoader class

and will rename

• Sitemap2 => Sitemap
• SitemapLoader2 => SitemapLoader

[kazurayam]

done at v0.11.0