search

kazurayam / materialstore

A domain-specific file system to store "materials" (screenshots, HTML, JSON, XML) collected during End-to-End testings using Selenium WebDriver etc. Features to make "diff" and compiling HTML reports are also included. This is written in pure Java8
Apache License 2.0
0 stars 0 forks source link

Source URL: file://null_object #313

Closed kazurayam closed 2 years ago

kazurayam commented 2 years ago

See the following screenshot.

スクリーンショット 2022-10-18 21 16 23

What is file://null_object?

kazurayam commented 2 years ago

I specified 

new Metadata.Builder(url).exclude("URL.protocol").build()

Because the "URL.protocol" attribute is excluded, it is not found in the MetadataAttributes. Therefore unable to rebuild a URL string from the MetadataAttributes.

kazurayam commented 2 years ago

I should not allow URL.protocol to be excluded. When specifed, should throw MaterialstoreException().

Not necessary to add such checking logic.

kazurayam commented 2 years ago

Metadata object should have a property of type java.net.URL. This will filled by new Metadata.Builder(URL).build() method. The property will be null unless this method was called.

Metadata#toURL() method should return this property of type java.net.URL.

Then the #313 will be fixed.

kazurayam commented 2 years ago
スクリーンショット 2022-10-19 17 55 15

This problem has been fixed.