search

kazurayam / materialstore

A domain-specific file system to store "materials" (screenshots, HTML, JSON, XML) collected during End-to-End testings using Selenium WebDriver etc. Features to make "diff" and compiling HTML reports are also included. This is written in pure Java8
Apache License 2.0
0 stars 0 forks source link

rename "int deleteMaterialsOlderThanExclusive()" method of "Store" to something more appropriate #319

Closed kazurayam closed 2 years ago

kazurayam commented 2 years ago

https://github.com/kazurayam/materialstore/blob/main/core/src/main/java/com/kazurayam/materialstore/filesystem/Store.java

The Store interface defines "int deleteMaterialsOlderThanExclusive()" method. I want to renamed it.

This name implies that it will delete Materials only.

Later I would change its functionality: I will delete the "report HTML" files with name where JobTimestamp is encoded.

But what should I name it ?

kazurayam commented 2 years ago

How about "int deleteStuffOlderThanExclusive"? Here I say "Stuff" rather than "Materials".

kazurayam commented 2 years ago

modified the implementation of deleteStuffOlderThanExclusive() a lot

kazurayam commented 2 years ago

done at 0.11.0-SNAPSHOT