kazurayam / materialstore

A domain-specific file system to store "materials" (screenshots, HTML, JSON, XML) collected during End-to-End testings using Selenium WebDriver etc. Features to make "diff" and compiling HTML reports are also included. This is written in pure Java8
Apache License 2.0
0 stars 0 forks source link

The name of HTML report should be in a fixted format. #320

Closed kazurayam closed 2 years ago

kazurayam commented 2 years ago

It should always be <JobName>-<JobTimestamp>.html.

kazurayam commented 2 years ago

v0.10.0, the Inspector interface has the following method signagures:

public abstract Path report(MProductGroup mProductGroup, Double criteria, String fileName) throws MaterialstoreException;

public abstract Path report(MProductGroup mProductGroup, SortKeys sortKeys, Double criteria, String fileName) throws MaterialstoreException;

public abstract Path report(MaterialList materialList, String fileName) throws MaterialstoreException;

public abstract Path report(MaterialList materialList, SortKeys sortKeys, String fileName) throws MaterialstoreException;

This should be changed to:

public abstract Path report(MProductGroup mProductGroup, Double criteria) throws MaterialstoreException;

public abstract Path report(MProductGroup mProductGroup, SortKeys sortKeys, Double criteria) throws MaterialstoreException;

public abstract Path report(MaterialList materialList) throws MaterialstoreException;

public abstract Path report(MaterialList materialList, SortKeys sortKeys) throws MaterialstoreException;

MProductGroup and MaterialList --- these objects contains the JobName object and the JobTimestamp object. No need to give JobName and JobTimestamp as parameter to the report() method.

The Inspector determines the file name, it should not ask users to determine the file name.

kazurayam commented 2 years ago

Inspector should also declare:

the new report methods will used these internally.

kazurayam commented 2 years ago

Done at 0.11.0-SNAPSHOT

スクリーンショット 2022-10-21 8 42 56