Closed kazurayam closed 2 years ago
v0.10.0, the Inspector
interface has the following method signagures:
public abstract Path report(MProductGroup mProductGroup, Double criteria, String fileName) throws MaterialstoreException;
public abstract Path report(MProductGroup mProductGroup, SortKeys sortKeys, Double criteria, String fileName) throws MaterialstoreException;
public abstract Path report(MaterialList materialList, String fileName) throws MaterialstoreException;
public abstract Path report(MaterialList materialList, SortKeys sortKeys, String fileName) throws MaterialstoreException;
This should be changed to:
public abstract Path report(MProductGroup mProductGroup, Double criteria) throws MaterialstoreException;
public abstract Path report(MProductGroup mProductGroup, SortKeys sortKeys, Double criteria) throws MaterialstoreException;
public abstract Path report(MaterialList materialList) throws MaterialstoreException;
public abstract Path report(MaterialList materialList, SortKeys sortKeys) throws MaterialstoreException;
MProductGroup and MaterialList --- these objects contains the JobName object and the JobTimestamp object. No need to give JobName and JobTimestamp as parameter to the report()
method.
The Inspector
determines the file name, it should not ask users to determine the file name.
Inspector should also declare:
String resolveReportFileName(MaterialList)
String resolveReportFileName(MaterialProductGroup)
the new report methods will used these internally.
Done at 0.11.0-SNAPSHOT
It should always be
<JobName>-<JobTimestamp>.html
.