com.kazurayam.materialstore.filesystem.Material#getId() should return an ID object, not a String object

kazurayam / materialstore

A domain-specific file system to store "materials" (screenshots, HTML, JSON, XML) collected during End-to-End testings using Selenium WebDriver etc. Features to make "diff" and compiling HTML reports are also included. This is written in pure Java8

Apache License 2.0

0 stars 0 forks source link

com.kazurayam.materialstore.filesystem.Material#getId() should return an ID object, not a String object #326

Closed kazurayam closed 2 years ago

kazurayam commented 2 years ago

in v0.11.0, com.kazurayam.materialstore.filesystem.Material#getId() returns a String.

This was a mistake.

It should return com.kazurayam.materialstore.filesystem.ID object

kazurayam commented 2 years ago

getId() is not good. It should be renamed to getID()

kazurayam commented 2 years ago

Material#getShortId() should be renamed to getShortID()

kazurayam commented 2 years ago

done at 0.11.1-SNAPSHOT