Closed kazurayam closed 1 year ago
I found that the test coverage of com.kazurayam.materialstore.base.inspector.InspectorTest
class + reduceAndSort() method is not versatile enough.
I should extend the InspectorTest first
Reducer#chronos() method implementation had a code:
if (previousMaterialList.size() == 0) {
throw new MaterialstoreException(
String.format("store.reflect(currentMaterialList) returned previousMaterialList of size == 0. " +
"currentMaterialList = %s/%s", currentMaterialList.getJobName().toString(),
currentMaterialList.getJobTimestamp().toString()));
}
This was just unnecessary.
I removed it.
derived from https://github.com/kazurayam/inspectus4katalon-sample-project/issues/8
When the store and store-backup directory is not present and ChronosDiff ran, an MaterialstoreException will be raised. Because of this code:
Reducer Line No.70
Is this check necessary?
It is better not to perform this check = do not throw Exception, and the Reducer silently performs comparison a real material against a void materia, resulting 100% diff.