search

kazurayam / materialstore

A domain-specific file system to store "materials" (screenshots, HTML, JSON, XML) collected during End-to-End testings using Selenium WebDriver etc. Features to make "diff" and compiling HTML reports are also included. This is written in pure Java8
Apache License 2.0
0 stars 0 forks source link

Is the com.kazurayam.materialstore.base.reduce.Reducer class not necessary? should be removed? #390

Open kazurayam opened 1 year ago

kazurayam commented 1 year ago

at v0.14.0, I checked by which classes the com.kazurayam.materialstore.base.reduce.Reducer class is used. I used IntelliJ IDEA's Find Usages feature.

スクリーンショット 2022-12-12 18 30 05

The result showed that the Reducer class is used only by "test classes". The Reducer class is not used by "main classes".

Really? I forgot this level of detail.

If the Reducer class is not used by "main classes", then I should rather deprecate it.

Let me check.

kazurayam commented 1 year ago

389 shows how the Reducer class is used.

Caused by: com.kazurayam.materialstore.core.filesystem.MaterialstoreException: store.reflect(currentMaterialList) returned previousMaterialList of size == 0. currentMaterialList = CURA/20221212_165311
    at com.kazurayam.materialstore.base.reduce.Reducer.chronos(Reducer.java:72)
    at com.kazurayam.materialstore.base.reduce.Reducer.chronos(Reducer.java:44)
    at com.kazurayam.materialstore.base.reduce.Reducer.chronos(Reducer.java:24)
    at com.kazurayam.inspectus.core.internal.ChronosDiff.step3_reduceChronos(ChronosDiff.java:68)

The Reducer class is not used by the main classes in the materialstore project.

But the Reducer class is used by the inspectus project and VisualInspectionInKatalonStudio_Reborn project

kazurayam commented 1 year ago

Possibly, the twins() method of Reducer class is not used by the inspectus project. Therefore the method can be removed.