kazurayam / selenium-webdriver-java

Examples of the O'Reilly book "Hands-On Selenium WebDriver with Java"
https://oreil.ly/1E7CX
Apache License 2.0
0 stars 0 forks source link

Why the master branch with Gradle 7.1 passed the CI/CD pipeline? #6

Open kazurayam opened 10 months ago

kazurayam commented 10 months ago

In the #3 , I found that gradle/wrapper/gradle-wrapper.properties file contained a line

distributionUrl=https\://services.gradle.org/distributions/gradle-7.1-bin.zip

I found Gradle 7.1 does not work with Java17. It emitted errors. Therefore I changed to Gradle 8.4; then build.gradle started running. However, the GitHub top page master branch shows that it is passing the whole CI/CD processing without any error.

Screenshot 2023-10-21 at 7 40 19

Now I have a doubt about the mark "build: passing". Is it worth trusting? I doubt it.

This

kazurayam commented 10 months ago

I should check if the CI/CD pipeline of the project refers to the gradle/wrapper/gradle-wrapper.properties file or not. If the pipeline only invokes the build by Maven and if it does not invokes Gradle, then the pipeline would miss any problems unique to the Gradle setups.

I should check if the CI/CD pipeline calles the ./gradlew command or the gradle command. If the gradle command is called, the gradle/wrapper/gradle-wrapper.properties file would not be used.