search

kb-dev-lab / UKit

Ukit, a companion app for student of University of Bordeaux
https://ukit-bordeaux.fr/
Apache License 2.0
14 stars 4 forks source link

URGENT: Use new URL #43

Closed Gogotron closed 3 years ago

Gogotron commented 3 years ago

I don't know why, but the university changed the URL required to access the calendar. The app shows no classes and throws an "undefined is not an object (evaluating 's.map')" error when opening the app.

Celcat isn't always reliable, I would suggest a cached schedule only be saved if it isn't empty, which would avoid Celcat errors from erasing the cache. Had this been how the cache worked before, many would not have noticed the errors today.

thclmnt commented 3 years ago

The app is currently using a proxy hosted by KBDev because React Native wouldn't allow API calls to Celcat website directly because of certificate issues, so changing this URL won't change anything. Also, the proxy URL can be changed really quickly without having to release a new version of the app and wait for student to download it, so it really should remain that way.

Gogotron commented 3 years ago

Given that the change in URL is relative, the new URL would still go through the proxy, and I believe it would work, as I have in fact tested. But of course, I agree, changing the proxy URL is much easier and practial.

Gogotron commented 3 years ago

While on the topic of certificates, I just accidentally found that I no longer get any errors regarding certificates. I'm speculating, but this may be the reason why there's been a change in the site. You should do your own testing, but it seems that, at least for now, the proxy isn't necessary.

thclmnt commented 3 years ago

I think the proxy will always be necessary as long as the university servers are subject to change It should be a good idea to keep it up at least for a few months, and only then consider changing it.

AamuLumi commented 3 years ago

Hey !

As @thclmnt explained, we keep the proxy while there are changes on the calendar address. When we will be ok with the Celcat managers, we will remove the proxy and changes URLs in the app.