kb-dk / MerMEId

Tool for editing MEI header data
Apache License 2.0
20 stars 14 forks source link

Instrument abbr generation is too aggressive #134

Closed tarjelavik closed 6 years ago

tarjelavik commented 6 years ago

In the source section of "Peer Gynt, op. 23" (http://ariel.uib.no/storage/present.xq?doc=dc70b04a-20bd-4569-9c68-160398fa77c8.xml) there is generated a <a class="abbr"> in the title page of a component.

In the example below "A." in "di A. Zanardini" is interpreted av "alto".

Italian-Spanish edition C. F. Peters, Leipzig December 1890. Title page: Melodia / per Canto / con Accompagnamento di Pianoforte / di / Edvardo Grieg. / Proprietà dell’Editore. / LEIPZIG / C. F. PETERS. / F. Baumgarten, del. ⇔ Lith. Anst. v. C. G. Röder, Leipzig. Heading: Canzone del Solvejg. / Cancion de Solvejg. / Versione ritmica italiana di A. Zanardini Traduccion española de J. Estremera.

I guess it is generated here: https://github.com/Det-Kongelige-Bibliotek/MerMEId/blob/47f56cf089be4af9533d56d61e25d3f8d98fac35/trunk/xqueries/style/mei_to_html.xsl#L3384

Is there a way to escape this if it is done intentionally or should the xslt be more strict?

axgeertinger commented 6 years ago

I changed this behaviour to be more strict in December 2017 with this commit. Are you sure you are using the latest version of mei_to_html.xsl? And are you sure A. Zanardini was not an alto? :-D

tarjelavik commented 6 years ago

Hehe, i have no idea, but he would have to be now! Software dictates reality.

Anyhow, no, we were not up to date. Sorry for the inconvenience!