search

kbadk / gmvault-webreader

Web interface for accessing Gmvault backups.
9 stars 0 forks source link

Just installed and testing things out a bit (docker version)....I have a couple of suggestions #18

Open pjones112000 opened 1 month ago

pjones112000 commented 1 month ago

Overall, it's looking pretty good...but, I do have a couple of suggestions:

1) When searching (particularly a large GMVault db folder), can a spinner or a message be displayed to indicate that the search is in progress? Initially I thought that it had come back with a result but that the results weren't making any sense before I realized that it was still searching.

2) Navigation buttons...once an email is opened, the only way back is the back button but that can present a problem if it's being executed from an iFrame. Additionally, it would be nice to be able to go to next/previous message (either the full list or the found list of results) while viewing the emails. Also a button to print the email would be nice.

3) Faster search...maybe a background process to build an index, perhaps even a command-line utility that can be executed after GMVault does its thing? I know you are currently using the Linux "find" and "xargs" commands for full-text searching, but, perhaps something like Xapien?

Again, what you've written is a serious step up from the default GMVault (essentially great at the archival bit but severely lacking at the post-archival functionality).

Thank you very much

kbadk commented 6 days ago

Hi there,

Thanks for the suggestions.

  1. I've implemented a spinner to indicate when a search is in progress or a page is loading, (https://github.com/kbadk/gmvault-webreader/commit/ce17da78cbb8dcc3f4140f2df6af4386ced8b154) and a back button (https://github.com/kbadk/gmvault-webreader/commit/283100e624f7406b9827b322fa09f045d99c49c1).

  2. The idea of adding "previous" and "next" message buttons is excellent. However, it’s a bit more complex to implement. Currently, when an email view page loads, it doesn’t have information about other emails or their positions in the list, which is pretty important when determining the previous or next message. It's definitely doable, but not something I'll put time into right now.

  3. I use this as a backup, in case I should ever lose access to my Gmail. In such a scenario, having to wait a little for emergency searching is acceptable to me. I had–6 years ago or so–built a prototype that used ElasticSearch, but it was far too memory hungry for this project for my taste.

    The current method of using find is definitely not a good solution, and I'm a little embarrassed about it. But it works. Even using ripgrep would probably speed up things a good deal.

    Xapian looks interesting and might be something I'll look into it. It doesn't seem to requirea full DBMS or a separate daemon, so it fits with the lightweight-ish nature of the application.

Also, PRs are of course welcome. If you decide to take a stab at something (like Xapian or prev/next buttons), I'll be happy to take a look at it. You are also welcome to reach out to me beforehand if you'd prefer (my email is on my profile).

Almost forgot: A new version has been auto-published with the changes on https://hub.docker.com/r/kbadk/gmvault-webreader.

pjones112000 commented 6 days ago
  1. Thank you….spinner works great.
  2. Fair enough…I might take a look at things
  3. I completely understand…have you considered SQLite as a backend? No daemons are required and still very light weight. I might take a look….I honestly haven’t even looked at what your application is written in. I have experience in a variety of languages but many I’m rusty on or I’ve just mainly for debugging purposes rather than writing from scratch, except perhaps C#.

I really like what you’ve done, the only thing I’m struggling with isn’t even your app but GMVault itself. I would like to be able to automated backing up but the token expires and I have to go through the process of recreating a token, etc… might was well manually run GMVault in that case. The problem I gather is on the Google end rather than GMVault… I’m not sure how other apps do it.

Anyway, thanks a lot….I’m still learning what it can do and what works well, what might need some attention and what would be nice to have…..but, so far, it’s by far the best I’ve seen working with GMVault.

Cheers,

Phil Jones.

From: Kristian Antonsen @.> Sent: Thursday, October 3, 2024 10:48 AM To: kbadk/gmvault-webreader @.> Cc: pjones112000 @.>; Author @.> Subject: Re: [kbadk/gmvault-webreader] Just installed and testing things out a bit (docker version)....I have a couple of suggestions (Issue #18)

Hi there,

Thanks for the suggestions.

  1. I've implemented a spinner to indicate when a search is in progress or a page is loading, ( https://github.com/kbadk/gmvault-webreader/commit/ce17da78cbb8dcc3f4140f2df6af4386ced8b154 ce17da7) and a back button ( https://github.com/kbadk/gmvault-webreader/commit/283100e624f7406b9827b322fa09f045d99c49c1 283100e).
  2. The idea of adding "previous" and "next" message buttons is excellent. However, it’s a bit more complex to implement. Currently, when an email view page loads, it doesn’t have information about other emails or their positions in the list, which is pretty important when determining the previous or next message. It's definitely doable, but not something I'll put time into right now.
  3. I use this as a backup, in case I should ever lose access to my Gmail. In such a scenario, having to wait a little for emergency searching is acceptable to me. I had–6 years ago or so–built a prototype that used ElasticSearch, but it was far too memory hungry for this project for my taste.

The current method of using find is definitely not a good solution, and I'm a little embarrassed about it. But it works. Even using ripgrep would probably speed up things a good deal.

Xapian looks interesting and might be something I'll look into it. It doesn't seem to requirea full DBMS or a separate daemon, so it fits with the lightweight-ish nature of the application.

Also, PRs are of course welcome. If you decide to take a stab at something (like Xapian or prev/next buttons), I'll be happy to take a look at it. You are also welcome to reach out to me beforehand if you'd prefer (my email is on my profile).

— Reply to this email directly, view it on GitHub https://github.com/kbadk/gmvault-webreader/issues/18#issuecomment-2391756990 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AM3RYPH53A54G3BJ7YP5V2TZZVRLTAVCNFSM6AAAAABNQQGNTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRG42TMOJZGA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AM3RYPHKVQ36YF7WJDMSMUDZZVRLTA5CNFSM6AAAAABNQQGNTOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUOR5IL4.gif Message ID: @. @.> >