search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 270 forks source link

Support 802.1ad vlan tags, MPLS fixes #426

Closed obormot closed 5 years ago

obormot commented 5 years ago

The change addresses 2 issues:

389 - We're not doing 802.1q and 802.1ad correctly in ethernet.py

425 - MPLS decoding to support PW ECW

... adds support for 802.1ad (long due), adds a couple new unit tests, and a small fix for incorrect fcs/trailer decoding.

Work mostly inspired by @smutt 's work on #389 and his PR #390 (which was unfortunately not reviewed for over a year and currently needs extra work to pass tests etc). I believe I've addressed all of @smutt 's concerns raised in #389.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 88.753% when pulling 1f849f130b74160d378a7c7357bdb094c89e99ba on support_802_1ad_vlan_tags into dca988968b66c315fe8f9c5d4051c78438f417d4 on master.