add new python versions to travis build

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols

Other

1.09k stars 270 forks source link

add new python versions to travis build #428

Closed brifordwylie closed 5 years ago

brifordwylie commented 5 years ago

Shrug.. there might be a better way to do this, but you need to tell Travis CI how to map tox env to Python version. Again I haven't looked at this in a while so might be a better/easier way.

brifordwylie commented 5 years ago

Hmm... Travis Python 3.7 has an issue (https://github.com/travis-ci/travis-ci/issues/9815).... putting in the work around now...

coveralls commented 5 years ago

Coverage remained the same at 88.717% when pulling 3aa323a807427887905946f66bdd86761cf6d09a on python_version_bump into 05090b5db77adcef3ad92cc2b95cb072c9db63bd on master.

brifordwylie commented 5 years ago

Ha... so now 3.7 works but 2.6 and pypy do not.... ;p

https://travis-ci.org/kbandla/dpkt/builds/458129811

@obormot you're the most active contributor... what do you want to do here? My suggestion:

Remove 3.7 test for now (so... 2.6, 2.7, 3.5, 3.6, and pypy)
I'll make a ticket for 3.7 support and look into it

obormot commented 5 years ago

interestingly 3.7 / tox worked fine in my local builds thanks @brifordwylie !

brifordwylie commented 5 years ago

@obormot "interestingly 3.7 / tox worked fine in my local builds" yep.. the code works fine with python 3.7.. the issue is the Travis CI machine installing running 3.7.... (see https://github.com/travis-ci/travis-ci/issues/9815)

brifordwylie commented 5 years ago

Added ticket for Python 3.7 (https://github.com/kbandla/dpkt/issues/429). This is now building fine with 2.6, 2,7, 3.5, 3.6 and pypy. So going to merge this in and we can add 3.7 later with ticket above.