search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 270 forks source link

Handle zero Eth Type #445

Closed kylekeppler closed 5 years ago

kylekeppler commented 5 years ago

This addresses issue #442.

Proposed solution:

Check for ethtype == 0 and handle as Ethernet II instead of IEEE 802.3 Ethernet - LLC. This is what Wireshark does.

kylekeppler commented 5 years ago

Looks like I broke a LLC test. I'll look into if that was a valid test case originally.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.04%) to 88.937% when pulling 805fdf59c2b3db28110597a3e68f3dadaa0b3d9f on kylekeppler:bugfix/zero-ethtype into 3b92c49e7e2691ff6fa3dff87b7925691a501ae9 on kbandla:master.

obormot commented 5 years ago

Good work. Thanks!