kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 270 forks source link

Remove python 2.6 support and add python 3.7 test coverage #450

Closed ngie-eign closed 5 years ago

ngie-eign commented 5 years ago

About 2.6:

python 2.6 has been unsupported for at least 4 years. Drop support for the python version as there have been several changes made in recent years to fix functional and security bugs with the interpreter, etc.

It's best to upgrade to python 2.7 (if one is stuck on 2.x), or upgrade to py3.

About 3.7:

python 3.7.0 was released 10 months ago. As such, it's reasonable to add test coverage to ensure it functions.

It is reasonably close feature-wise to 3.6 that there will unlikely be any behavioral difference in this package. Some of the benefits of 3.7 over earlier versions is improved asyncio module support and general performance improvements.

More information about what's new in 3.7 can be found here.

About the Travis changes:

About dpkt.decorators:

As part of this work, I realized that dpkt.decorators was unused. As such, reap all references to the module and the module itself.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 89.05% when pulling 1898aa86549113adb4702780e90824b5bfb04032 on ngie-eign:remove-py26-add-py37-support into 4c4749acd1a231e75384fb1eb5543245f730ba8c on kbandla:master.

ngie-eign commented 5 years ago

@kbandla: ping?

obormot commented 5 years ago

this would also close #429
looks like Travis is happy w/ py3.7 now. cool