search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 271 forks source link

Fix QinQ vlan tag parsing with miscellaneous data #466

Closed EliScada closed 4 years ago

EliScada commented 4 years ago

Fix issue https://github.com/kbandla/dpkt/issues/465

Change scope of next_type variable.

Add unit test:

  1. Verify nested eth_type
  2. Data part left intact
EliScada commented 4 years ago

Hi @obormot I saw you have a thorough acquaintance with the ethernet module, would be great if you could find the time to have a look. Thanks Eli

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.005%) to 89.096% when pulling b3fb32a758f3376dabc2b9f5aee7e693a10ae6c5 on EliScada:fix-vlan_QinQ_next_type into 0aa3a6e9c7cce3a54b8c10691f3271f6f0ca95a5 on kbandla:master.

EliScada commented 4 years ago

Thanks for the review @obormot