kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 270 forks source link

Adding Power support(ppc64le) with ci and testing to the project for architecture independent #497

Closed asellappen closed 3 years ago

asellappen commented 3 years ago

I am working for IBM to port cpu arch ppc64le for open sources.

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date.

This helps us simplify testing later when distributions are re-building and re-releasing,We typically build applications for customers and ISVs, and while we don't use this package directly,we do count on all of the packages in debian/ubuntu to build other packages. So we more likely have this as a second or third level dependency and couldn't tell you explicitly which features we use or our usage model,For more info tag @gerrith3.

Please help to verify and merge.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 89.642% when pulling f09a389a7ce0fb0db826ae0751188ce0d6c3620d on asellappen:master into dd27de917eee085678f187cc6bc9c8ed52d104c6 on kbandla:master.

brifordwylie commented 3 years ago

Hi @asellappen Thanks for the PR.. so we actually going to remove Travis from our CI/CD and start using Github Actions.

So, would love for you to figure out how to the do the equivalent ARCH switch with Github Actions if possible :)

If you don't get a chance.. I'll read up on how to do it.

Closing this PR, and we'll try to figure out how to do this with Github Actions....

shrug.. maybe this? https://github.com/uraimo/run-on-arch-action

Created new issue here: #519