search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.08k stars 270 forks source link

Improve radiotap #517

Closed obormot closed 3 years ago

obormot commented 3 years ago

This picks up on great work in PR https://github.com/kbandla/dpkt/pull/478 that had some issues with usage of bytearray and wasn't backward compatible with existing unit tests (which as I and others noticed contained some endianness issues). I've added the original unit tests back and adjusted the code to be backward compatible. Tested on both little and big endian architectures. This is by large just an incremental improvement/bugfix to radiotap module.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.08%) to 92.565% when pulling cfa04214f630c34c8f731beb6f4125fdf9676beb on improve-radiotap into f9ec494b3dfb4647748c0bfd7f590ba4afacfe71 on master.

brifordwylie commented 3 years ago

@obormot LGTM, feel free to merge at your convenience.

obormot commented 3 years ago

@obormot LGTM, feel free to merge at your convenience.

Thanks! I'll try adding some more unit tests before merging.