fix #512 - flake8 F82 cleanup

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols

Other

1.09k stars 270 forks source link

fix #512 - flake8 F82 cleanup #518

Closed obormot closed 3 years ago

obormot commented 3 years ago

add # noqua to all lines in pcap.py, pcapng.py where flake8 is throwing a F82 warning; all of these are inside unit tests so safe/harmless..
refactor basestring in ethernet.py

no F82 errors after the change

(dpkt)$ flake8 . --count --select=F82 --show-source --statistics
0

coveralls commented 3 years ago

Coverage increased (+0.02%) to 92.49% when pulling 6939493792ce0166060a951ad3aebf233773dda1 on flake8-cleanup into b5efa3304bf976d561851842b7622f4801405b1d on master.

brifordwylie commented 3 years ago

@obormot LGTM, go ahead and merge. After that I'll go back and add the flake F82 test back to the github actions