search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 270 forks source link

Update radiotap attribute setters. #532

Closed crocogorical closed 3 years ago

crocogorical commented 3 years ago

Previous implementation had inconsistency between getters (expecting array of bytes), and setters (expecting an int), which meant all setters would fail.

All previous tests pass, and new ones test the getters/setters.

brifordwylie commented 3 years ago

Looks good to me...shrug.. not really familiar with radiotap but the changes look solid.