search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.09k stars 270 forks source link

Extend dpkt.py testing to 100%. #546

Closed crocogorical closed 3 years ago

crocogorical commented 3 years ago

No modifications to the operational code, just addition of tests.

Unless there are any objections, I'll merge this, #545, #543, #542, and #541 in the next couple of days as they add tests, and don't modify the operational code.

brifordwylie commented 3 years ago

@crocogorical since you have developer privileges now, you can merge in PRs on your own. Also branches should now come off this repo instead of yours. If you're making changes that affect the functionality in a way that might break/change functionality... you can include a reviewer :)

crocogorical commented 3 years ago

Awesome, thanks @brifordwylie. Wasn't quite sure on the etiquette!