kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.08k stars 270 forks source link

Remove unreachable exception handling in ip6.py #547

Closed crocogorical closed 3 years ago

crocogorical commented 3 years ago

During packing of IP6 instances, it does not appear to be possible to raise an AttributeError during this section of code.

It is possible that self.data.sum could be read-only, which would raise an AttributeError when trying to write to it.

I cannot think of a way to generate this exception, so we should remove the code, or design a test for it.

brifordwylie commented 3 years ago

@crocogorical Feel free to merge at your convenience