search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.08k stars 270 forks source link

do not recognise CipherSuite 0x1301 TLS_AES_128_GCM_SHA256 #559

Closed RonaldinhoL closed 3 years ago

RonaldinhoL commented 3 years ago

seems its tls1.3 [RFC8446]

arunppsg commented 3 years ago

Try downgrading dpkt to version 1.9.3 or lower. Had the same issue and downgrading resolved it.

RonaldinhoL commented 3 years ago

for tmp solution, i have edited dpkt code and added some tls1.3 suite to it and it worked.

brifordwylie commented 3 years ago

Hmm... @RonaldinhoL since we have a skeleton crew of maintainers... could you provide:

obormot commented 3 years ago

@RonaldinhoL We welcome pull requests! If your change solves the issue you raised this sounds like a perfect candidate for a contribution.

I've drafted this change, is this similar to what you have in mind? https://github.com/kbandla/dpkt/commit/a67f5887fd8fec6d62fd80e46c67dfaa32afb299

RonaldinhoL commented 3 years ago

@RonaldinhoL We welcome pull requests! If your change solves the issue you raised this sounds like a perfect candidate for a contribution.

I've drafted this change, is this similar to what you have in mind? a67f588

yes, i did same as you

obormot commented 3 years ago

change merged, closing