search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.08k stars 270 forks source link

Misc cleanup #606

Closed brifordwylie closed 2 years ago

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 99.814% when pulling 147b81c1e038c1e9b939e1339c75723b5275cfdb on misc_cleanup into 7dbb6c0afad04cf9dedeb8d018a2c7744c645d77 on master.

obormot commented 2 years ago

@brifordwylie any clues to why Coveralls show decreased coverage whereas the change is 0.0%? (like here) When opening the report there's no decrease in coverage. Feels like there's a condition somewhere that says 

if change > 0      # but it should be >=
  green
else
  red
brifordwylie commented 2 years ago

@obormot @kbandla We can change the 'decrease threshold' (see https://github.com/MapServer/MapServer/issues/6223) I don't have access so @kbandla will have to do it... (go here https://coveralls.io/github/kbandla/dpkt/settings)