search

kbandla / dpkt

fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols
Other
1.08k stars 270 forks source link

Coveralls failures are misleading #641

Open obormot opened 1 year ago

obormot commented 1 year ago

Those "coverage decreased" failures are bogus and appear when the coverage has not changed at all, which can be confirmed by looking at the detailed report in Coveralls. There should be a setting that can be tweaked to fix this.

image
kbandla commented 1 year ago

I will look into this. A quick look reveals what coveralls thinks is wrong.

obormot commented 1 year ago

Yes it does report something, but this specific piece of code didn't change => there's no drop in coverage. Perhaps there's a threshold that can be adjusted, like "treat any change below 0.1% as no change"

obormot commented 1 year ago

Here's another example of this. PR #646 - no change in coverage; Coveralls is all over the place.

image