search

kbandla / pydeep

Python bindings for ssdeep
Other
91 stars 33 forks source link

Added python3 support. #11

Closed hlein closed 8 years ago

hlein commented 9 years ago

The most substantial changes were due to the module initialization changes in python3; also some string->binary changes. Based most of my changes on on https://docs.python.org/3/howto/cporting.html and a few random projects I reviewed. The code remains python2-compatible. Also updated test.py, and added support for 'python[23] setup.py test' after build.

hlein commented 9 years ago

Ping ;) I would like to encourage an existing project to switch to pydeep, but their code is python3, so would need this (or some better changes) landed first.

kbandla commented 9 years ago

ack @hlein. Thanks a lot for the PR. Going to test it out on my corpus

kbandla commented 9 years ago

@hlein the code looks good. I cleaned up the code a little bit and created the py3 branch. Quick review please?

hlein commented 9 years ago

Thanks! ...In the meantime I lost all my free time, but briefly looking over the py3 commit it looks good to me (and cleaner than my attempt).

kbandla commented 8 years ago

Added in #12