kbarbary / Dierckx.jl

Julia package for 1-d and 2-d splines
Other
157 stars 30 forks source link

Use Dierckx_jll to provide the library #65

Closed giordano closed 4 years ago

giordano commented 4 years ago

Also, some improvement to CI:

giordano commented 4 years ago

Updated julia versions to 1.4

Why? Julia v1.3 is the minimum version we declare is compatible with this package, why we shouldn't test it?

kaarthiksundar commented 4 years ago

Updated julia versions to 1.4

Why? Julia v1.3 is the minimum version we declare is compatible with this package, why we shouldn't test it?

I think we declare Julia v1.0 as the minimum compatible version. So, we ensure the tests passes in the minimum supported version and the latest version of Julia which is v1.4.

giordano commented 4 years ago

I think we declare Julia v1.0 as the minimum compatible version.

Well, not anymore after this pull request

giordano commented 4 years ago

and the latest version of Julia which is v1.4.

That's what julia v1 stands for

kaarthiksundar commented 4 years ago

and the latest version of Julia which is v1.4.

That's what julia v1 stands for

Sorry my bad, I did not know this. Fixed

kaarthiksundar commented 4 years ago

I think we declare Julia v1.0 as the minimum compatible version.

Well, not anymore after this pull request

Thanks, reverted back.

giordano commented 4 years ago

Thanks!

kbarbary commented 4 years ago

Will this help with #63, or do you think that's a separate issue? I haven't kept up with the state of BinaryBuilder/Provider.

giordano commented 4 years ago

Yes, the JLL packages should be much more reliable, so failures like that should be gone