kbase / KbaseAppCatalogStatic

MIT License
0 stars 3 forks source link

Prefix local paths with {{ conf.PATH_PREFIX }} #27

Closed eapearson closed 3 years ago

eapearson commented 3 years ago

This app runs at the path root /applist/. The pre-existing PATH_PREFIX config was previously applied this to the web app config. Now it is applied to local urls as well.

eapearson commented 3 years ago

Checked the codebase, glyph icons are not even used. Just fontawesome. Removed the extra glyphicon load, didn't notice any difference nor any errors, etc.

eapearson commented 3 years ago

BTW one way to test this is to try to access the app at http://localhost:5000/x, see it fail, then update the config for ROOT_PREFIX to /x, then see it work. Then revert to /applist, see it fail, then access it at http://localhost:5000/applist and see it succeed.

briehl commented 3 years ago

Yup, did all the testing that way, and it works.