search

kbase / auth2

KBase authentication server MKII
MIT License
1 stars 9 forks source link

PTV-1890: Fix login bug wrt anonymous IDs #408

Closed MrCreosote closed 1 year ago

MrCreosote commented 1 year ago

Somehow missed updating the getUser(RemoteIdentity) method when I updated getUser(UserName). Sloppy.

One other issue is I still don't understand is why the ExceptionHandler didn't print out the full stacktrace from the NPE thrown by UUID.fromString like it does for all the other exceptions in the log.

codecov[bot] commented 1 year ago

Codecov Report

Merging #408 (54e1523) into develop (a91d0a9) will decrease coverage by 0.03%. The diff coverage is 85.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #408 +/- ## ============================================= - Coverage 93.40% 93.37% -0.03% - Complexity 2139 2141 +2 ============================================= Files 126 126 Lines 7516 7519 +3 Branches 1176 1177 +1 ============================================= + Hits 7020 7021 +1 - Misses 453 455 +2 Partials 43 43 ```
MrCreosote commented 1 year ago

Since logins are broken in CI, I'm going to merge this and deploy, but will make any necessary changes based on @briehl 's review here

briehl commented 1 year ago

I hereby grant this Pull Request the height of my esteem and provide my humble approval.