kbase / auth2

KBase authentication server MKII
MIT License
1 stars 9 forks source link

Upgrade to MongoDB 7.0.4 #415

Closed Xiangs18 closed 9 months ago

Xiangs18 commented 10 months ago

@MrCreosote Still got 2 test suites fail:

  1. us.kbase.test.auth2.lib.storage.mongo.MongoStorageDuplicateKeyCheckerTest (Test run: 8 Failures: 1) https://github.com/kbase/auth2/actions/runs/7203197479/job/19622675398?pr=415#step:6:2462
  2. us.kbase.test.auth2.lib.storage.mongo.MongoStorageStartUpTest(Test run: 17 Failures: 12) https://github.com/kbase/auth2/actions/runs/7203197479/job/19622675540?pr=415#step:6:2794
MrCreosote commented 10 months ago

What help do you need?

Xiangs18 commented 10 months ago

Most tests in 2 failed because there is no expected ns= in each document. Not sure why, still investigating....

For instance:

[junit] Expected: is <[Document{{v=2, key=Document{{_id=1}}, name=_id_, ns=test_mongostorage.config_prov}}, Document{{v=2, unique=true, key=Document{{prov=1, key=1}}, name=prov_1_key_1, ns=test_mongostorage.config_prov}}]>
[junit]      but: was <[Document{{v=2, key=Document{{prov=1, key=1}}, name=prov_1_key_1, unique=true}}, Document{{v=2, key=Document{{_id=1}}, name=_id_}}]>
MrCreosote commented 10 months ago

I'm pretty sure I remember that the ns key being removed the release notes. You probably need to update the mongo test manager class to detect the version and modify the tests appropriately for v7

Xiangs18 commented 10 months ago

You probably need to update the mongo test manager class to detect the version and modify the tests appropriately for v7

Are we updating to v7? why do we still keep v3 and run tests on it?

MrCreosote commented 10 months ago

Because v3 is in production right now. We need to update the servers to work on either v3 or v7 and then we can switch over

Xiangs18 commented 9 months ago

Any clue why I keep getting operation canceled in ubuntu2204-7.0.4? I would expect some tests to fail, but not canceled...

MrCreosote commented 9 months ago

No idea, that's a new one to me. Do the tests pass locally?

codecov[bot] commented 9 months ago

Codecov Report

Merging #415 (a518c1b) into master (1408e96) will increase coverage by 0.01%. The diff coverage is 75.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #415 +/- ## ============================================ + Coverage 93.37% 93.39% +0.01% - Complexity 2141 2142 +1 ============================================ Files 126 126 Lines 7519 7520 +1 Branches 1177 1178 +1 ============================================ + Hits 7021 7023 +2 + Misses 455 454 -1 Partials 43 43 ```