Closed MrCreosote closed 8 months ago
Merging #419 (8fce168) into develop (09b2011) will not change coverage. Report is 1 commits behind head on develop. The diff coverage is
n/a
.
@MrCreosote Do you think we are ready to remove .classpath as well?
Do you think we are ready to remove .classpath as well?
It's removed in the next commit after I get Eclipse builds working (with a minor annoyance, but working)
@MrCreosote
I am a little bit confused about 3 tasks: generateTemplateFileList
, fatTestJar
, and generateManageAuthScript
. Could you please explain more why we need each of them?
I am a little bit confused about 3 tasks: generateTemplateFileList, fatTestJar, and generateManageAuthScript. Could you please explain more why we need each of them?
Easy one first: generateManageAuthScript generates this: https://github.com/kbase/auth2/blob/develop/README.md?plain=1#L260
generateTemplateFileList creates a list of all the templates (a manifest) in the templates
directory. This is solely to make it easier for the test rig to pull the templates out of the fat test jar, as listing directories inside a jar is unnecessarily difficult.
fatTestJar generates a fat test jar, including all dependencies, the templates, and the templates manifest. The fat jar will replace the current auth jar + the jars repo in workspace and other repos for running an auth2 server in their test rigs. The fat jar is completely self contained, so the jars repo is no longer needed
@MrCreosote And where will this fat jar locate in the repo? I cannot find it anywhere after running fatTestJar task.
And where will this fat jar locate in the repo? I cannot find it anywhere after running fatTestJar task.
It's in build/libs
This PR is a bit large but for me it was easier to understand the changes with the full ant -> gradle conversion. Instead, the PR is split up mostly by commit - the first commit gets the basics (compile & test) working, and then each new commit adds a new feature (or in the case of the last commit, improves an old one).
I found that Eclipse Buildship really doesn't like our project layout, and so the next PR will switch the project to a standard Gradle layout, but that involves moving every single source file, so... different PR.