search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Handle http client errors correctly #10

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Definitely don't want to return the presigned url in the error string

Adds a test with an incorrect data size

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will increase coverage by 1.76%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   67.25%   69.02%   +1.76%     
==========================================
  Files           4        4              
  Lines         113      113              
==========================================
+ Hits           76       78       +2     
+ Misses         32       31       -1     
+ Partials        5        4       -1
Impacted Files Coverage Δ
filestore/s3.go 77.77% <100%> (+3.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e79910...b489afe. Read the comment docs.