kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Clean up python MIME upload example #112

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Also remove some TODOs:

Default max header len is 1MB, so adding a timeout as well doesn't really seem necessary.

For details: https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/

codecov[bot] commented 5 years ago

Codecov Report

Merging #112 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          14       14           
  Lines        1543     1543           
=======================================
  Hits         1410     1410           
  Misses         99       99           
  Partials       34       34
Impacted Files Coverage Δ
service/server.go 97.81% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fdd744...957465c. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #112 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          14       14           
  Lines        1543     1543           
=======================================
  Hits         1410     1410           
  Misses         99       99           
  Partials       34       34
Impacted Files Coverage Δ
service/server.go 97.81% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fdd744...957465c. Read the comment docs.