search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Fix tests #125

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

CI now returns 200 for any invalid URL...

Also updated to use the latest versions of Mongo 3.6

codecov[bot] commented 3 years ago

Codecov Report

Merging #125 into develop will decrease coverage by 0.74%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    91.54%   90.80%   -0.75%     
===========================================
  Files           14       14              
  Lines         1562     1381     -181     
===========================================
- Hits          1430     1254     -176     
+ Misses          99       94       -5     
  Partials        33       33
Impacted Files Coverage Δ
service/build.go 59.57% <0.00%> (-2.69%) :arrow_down:
nodestore/mongostore.go 84.21% <0.00%> (-1.97%) :arrow_down:
filestore/s3.go 87.87% <0.00%> (-0.86%) :arrow_down:
auth/kbase_provider.go 93.63% <0.00%> (-0.72%) :arrow_down:
service/server.go 97.71% <0.00%> (-0.18%) :arrow_down:
app/blobstore.go 0.00% <0.00%> (ø)
config/config.go 100.00% <0.00%> (ø)
auth/interface.go 100.00% <0.00%> (ø)
core/values/values.go 100.00% <0.00%> (ø)
service/errortypes.go 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03db095...5cf21f9. Read the comment docs.

MrCreosote commented 3 years ago

The coverage changes appear to be due to a change in the coverage calculation rather than any real loss in test coverage: https://codecov.io/gh/kbase/blobstore/pull/125/changes