search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Add range selector when getting files to s3 store. #126

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

Next steps: continue pushing up through the stack towards the API.

codecov[bot] commented 3 years ago

Codecov Report

Merging #126 (8547218) into develop (5cf21f9) will increase coverage by 0.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #126      +/-   ##
===========================================
+ Coverage    90.80%   91.02%   +0.21%     
===========================================
  Files           14       14              
  Lines         1381     1392      +11     
===========================================
+ Hits          1254     1267      +13     
+ Misses          94       92       -2     
  Partials        33       33
Impacted Files Coverage Δ
filestore/interface.go 100.00% <ø> (ø)
core/core.go 99.41% <100.00%> (ø)
filestore/s3.go 90.20% <100.00%> (+2.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cf21f9...8547218. Read the comment docs.

MrCreosote commented 3 years ago

To be clear this is just changing the s3 implementation - the server API has no changes yet. Few more PRs.