kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

S3 disable ssl verify #131

Closed kkellerlbl closed 3 years ago

kkellerlbl commented 3 years ago

Add a configuration option (default to false) that disables verification of the S3 SSL certificate (for example, if it is self-signed).

codecov[bot] commented 3 years ago

Codecov Report

Merging #131 (3d4ff6f) into s3-disable-ssl-verify (5db1e52) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           s3-disable-ssl-verify     #131      +/-   ##
=========================================================
+ Coverage                  91.14%   91.20%   +0.05%     
=========================================================
  Files                         14       14              
  Lines                       1412     1421       +9     
=========================================================
+ Hits                        1287     1296       +9     
  Misses                        92       92              
  Partials                      33       33              
Impacted Files Coverage Δ
config/config.go 100.00% <100.00%> (ø)
filestore/s3.go 90.41% <100.00%> (+0.20%) :arrow_up:
service/build.go 62.74% <100.00%> (+3.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5db1e52...3d4ff6f. Read the comment docs.