Closed kkellerlbl closed 3 years ago
Merging #133 (b56d832) into s3-disable-ssl-verify (3d4ff6f) will decrease coverage by
0.06%
. The diff coverage is78.57%
.
@@ Coverage Diff @@
## s3-disable-ssl-verify #133 +/- ##
=========================================================
- Coverage 91.20% 91.13% -0.07%
=========================================================
Files 14 14
Lines 1421 1422 +1
=========================================================
Hits 1296 1296
- Misses 92 93 +1
Partials 33 33
Impacted Files | Coverage Δ | |
---|---|---|
app/blobstore.go | 0.00% <0.00%> (ø) |
|
filestore/s3.go | 90.34% <100.00%> (-0.07%) |
:arrow_down: |
service/build.go | 63.46% <100.00%> (+0.71%) |
:arrow_up: |
service/server.go | 97.79% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 266aa7b...b56d832. Read the comment docs.
There's something weird going on with the tests. They clearly ran on this PR: https://www.travis-ci.com/github/kbase/blobstore/builds/208241032
But they don't seem to be running any more
But they ran on commit 9b121c8 which isn't in this PR
Looks like tests are running again
Updating based on Gavin's comments.