kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

improvements to s3-disable-ssl-verify config option #133

Closed kkellerlbl closed 3 years ago

kkellerlbl commented 3 years ago

Updating based on Gavin's comments.

codecov[bot] commented 3 years ago

Codecov Report

Merging #133 (b56d832) into s3-disable-ssl-verify (3d4ff6f) will decrease coverage by 0.06%. The diff coverage is 78.57%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           s3-disable-ssl-verify     #133      +/-   ##
=========================================================
- Coverage                  91.20%   91.13%   -0.07%     
=========================================================
  Files                         14       14              
  Lines                       1421     1422       +1     
=========================================================
  Hits                        1296     1296              
- Misses                        92       93       +1     
  Partials                      33       33              
Impacted Files Coverage Δ
app/blobstore.go 0.00% <0.00%> (ø)
filestore/s3.go 90.34% <100.00%> (-0.07%) :arrow_down:
service/build.go 63.46% <100.00%> (+0.71%) :arrow_up:
service/server.go 97.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 266aa7b...b56d832. Read the comment docs.

MrCreosote commented 3 years ago

There's something weird going on with the tests. They clearly ran on this PR: https://www.travis-ci.com/github/kbase/blobstore/builds/208241032

But they don't seem to be running any more

MrCreosote commented 3 years ago

But they ran on commit 9b121c8 which isn't in this PR

MrCreosote commented 3 years ago

Looks like tests are running again