kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

DEVOPS-1990 Update to go 1.16 #151

Closed bio-boris closed 1 month ago

bio-boris commented 1 month ago

from

This is where it's happening https://github.com/kbase/blobstore/blob/1cc0178ee0a3814aef917b5d4882d52565911494/filestore/s3.go#L151

[s3.go](https://github.com/kbase/blobstore/blob/1cc0178ee0a3814aef917b5d4882d52565911494/filestore/s3.go)
        return nil, errors.New("s3 store request: " + errstr)

Attempted solution is to upgrade the httplib

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.83%. Comparing base (1cc0178) to head (1fd4d89).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #151 +/- ## ======================================== Coverage 90.83% 90.83% ======================================== Files 14 14 Lines 2073 2073 ======================================== Hits 1883 1883 Misses 157 157 Partials 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MrCreosote commented 1 month ago

Given we've seen this problem twice in 5 years we're going to have a hard time confirming it's fixed

MrCreosote commented 1 month ago

forgot to mention we'll need release notes and a version bump at some point