search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Attempt to fix time issues on Store/Get file test #39

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

For storing the file, the returned time is parsed from the headers returned by the http request, which apparently is not always identical to the time returned by the S3 client. Use the S3 client to get the time after storing the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #39 into master will not change coverage. The diff coverage is 75%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #39   +/-   ##
======================================
  Coverage    87.5%   87.5%           
======================================
  Files          10      10           
  Lines         624     624           
======================================
  Hits          546     546           
  Misses         63      63           
  Partials       15      15
Impacted Files Coverage Δ
filestore/s3.go 86.91% <75%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb23c88...890b394. Read the comment docs.