search

kbase / blobstore

Simple S3 backed file storage.
MIT License
0 stars 3 forks source link

Take a another crack a fixing failing tests #49

Closed MrCreosote closed 5 years ago

MrCreosote commented 5 years ago

Tests that check that a time is close to now +/- 1 sec sometimes fail.

I think this is because S3 always rounds the time down, and so if the time is close to the next second, it gets rounded down, and then if the time flips over to the next second before the test, the test fails. Usually the test time when it fails is just barely over the second mark.

codecov[bot] commented 5 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          12       12           
  Lines         797      797           
=======================================
  Hits          697      697           
  Misses         78       78           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4087ad9...f46f520. Read the comment docs.